Don't have the source code either.. If you don't mind how are you using it in your trading? Maybe can make a version or maybe try the chaos version, think this would be an upgraded haos visual.poaslk wrote: ↑Wed Sep 09, 2020 4:16 amHey, can I kindly ask you to add some performance checks and out of range arrays and fix memory leaks?
- 1) performance checks: when I call, mostly I get:
Code: Select all
iCustom(TRs,tT,"HaosVisual Averages",tZ,tY,tX,tV,-tV,tZ,tY,tX,tV,-tV,false,6,1)2020.09.08 19:25:12.787 HaosVisual Averages NZDCHF,M5: indicator is too slow, 5281 ms. rewrite the indicator, please
It goes up to 10000ms!!!
Suggestion: Can you add external variable to limit the amount of history bars calculated? Make no sense to calculate all history chart Bars. I need only last 3 months, maximum around 18000 bars for M5. Can you also make check if FirstWPR_values are equal to SecondWPR_values, not to calculate both WPRs? Or remove one and leave only one? I need only one. Or can you give option to remove calculation of one? This will speed up indicator calling. Make no sense to calculate both if only one result can be obtained through iCustom.
- 2) out of range arrays:This happens for any smoothing method for any parameter, so it must be specific for the M5 and/or M15 periods. It looks like there is limit on history bars. Can you make sure that maximum arrays sizes are at least 18000? 3 months for M5?2020.09.08 19:24:48.098 HaosVisual Averages EURJPY,M5: array out of range in 'HaosVisual averages.mq4' (705,14)
I would fix it and tweak performance by myself, but no source code. Let me know if you need to run debug version on my terminal for further details. I can do testing for you.
- 3) memory leaks:This might be related to array out of range, I cannot say or guess. I have 8Gb memory and MT4 eats it fast when I'm calling iCustoms on your indicator. It happens only when out of range arrays errors are presents, so it is probably memory leak caused by arrays.2020.09.08 19:24:36.063 HaosVisual Averages EURJPY,M5: out of memory
Anyway, great indicator, except performance issues. Thanks!