.

Re: Coding Help

#1061
Cladi39 wrote:
Mon Oct 07, 2019 7:58 am
Hello mrtools im trying to do iCustom based indicator that show a signal when indicator is blue(up) and red(down), For down seems to work well, but my problem is sometimes is a up signal in red line, attached picture and code. Will be great if you can help me. Thanks soo much.

PD: maybe you can put arrows with buffers directly on indicator soo i can use it with iCustom.
Slope direction line is a repainting hull or hma moving average.


Re: Coding Help

#1062
mrtools wrote:
Mon Oct 07, 2019 10:24 am
Cladi39 wrote:
Mon Oct 07, 2019 7:58 am
Hello mrtools im trying to do iCustom based indicator that show a signal when indicator is blue(up) and red(down), For down seems to work well, but my problem is sometimes is a up signal in red line, attached picture and code. Will be great if you can help me. Thanks soo much.

PD: maybe you can put arrows with buffers directly on indicator soo i can use it with iCustom.
Slope direction line is a repainting hull or hma moving average.
Thanks Mrtools and the attached version can work?
Hull separate nrp mtf.mq4
(5.85 KiB) Downloaded 103 times

Re: Coding Help

#1063
Cladi39 wrote:
Mon Oct 07, 2019 11:06 am
mrtools wrote:
Mon Oct 07, 2019 10:24 am


Slope direction line is a repainting hull or hma moving average.
Thanks Mrtools and the attached version can work?
That will work if you are wanting to call it from an EA just use the trend buffer #6.

Re: Coding Help

#1064
mrtools wrote:
Mon Oct 07, 2019 11:52 am
Cladi39 wrote:
Mon Oct 07, 2019 11:06 am


Thanks Mrtools and the attached version can work?
That will work if you are wanting to call it from an EA just use the trend buffer #6.
Thanks soo much Mrtools. I use buffer 0 this way and work soo well.
Slope Test.png

Re: Coding Help

#1065
mrtools

I have a question.
If I'm not mistaken, this is a snippet for nrp coloring.

Code: Select all

void CleanPoint(int i,double& first[],double& second[])
{
   if (i>=Bars-3) return;
   if ((second[i]  != EMPTY_VALUE) && (second[i+1] != EMPTY_VALUE))
        second[i+1] = EMPTY_VALUE;
   else
      if ((first[i] != EMPTY_VALUE) && (first[i+1] != EMPTY_VALUE) && (first[i+2] == EMPTY_VALUE))
          first[i+1] = EMPTY_VALUE;
}

void PlotPoint(int i,double& first[],double& second[],double& from[])
{
   if (i>=Bars-2) return;
   if (first[i+1] == EMPTY_VALUE)
      if (first[i+2] == EMPTY_VALUE) 
            { first[i]  = from[i];  first[i+1]  = from[i+1]; second[i] = EMPTY_VALUE; }
      else  { second[i] = from[i];  second[i+1] = from[i+1]; first[i]  = EMPTY_VALUE; }
   else     { first[i]  = from[i];                           second[i] = EMPTY_VALUE; }
}
There are some indicators that don't have these two lines.

Code: Select all

if (i>=Bars-3) return;
if (i>=Bars-2) return;
Do those two lines affect nrp coloring?


Re: Coding Help

#1066
ruden wrote:
Mon Oct 07, 2019 9:38 pm
mrtools

I have a question.
If I'm not mistaken, this is a snippet for nrp coloring.

Code: Select all

void CleanPoint(int i,double& first[],double& second[])
{
   if (i>=Bars-3) return;
   if ((second[i]  != EMPTY_VALUE) && (second[i+1] != EMPTY_VALUE))
        second[i+1] = EMPTY_VALUE;
   else
      if ((first[i] != EMPTY_VALUE) && (first[i+1] != EMPTY_VALUE) && (first[i+2] == EMPTY_VALUE))
          first[i+1] = EMPTY_VALUE;
}

void PlotPoint(int i,double& first[],double& second[],double& from[])
{
   if (i>=Bars-2) return;
   if (first[i+1] == EMPTY_VALUE)
      if (first[i+2] == EMPTY_VALUE) 
            { first[i]  = from[i];  first[i+1]  = from[i+1]; second[i] = EMPTY_VALUE; }
      else  { second[i] = from[i];  second[i+1] = from[i+1]; first[i]  = EMPTY_VALUE; }
   else     { first[i]  = from[i];                           second[i] = EMPTY_VALUE; }
}
There are some indicators that don't have these two lines.

Code: Select all

if (i>=Bars-3) return;
if (i>=Bars-2) return;
Do those two lines affect nrp coloring?
Yes those 2 lines are added for using #property strict.

Re: Coding Help

#1067
mrtools wrote:
Tue Oct 08, 2019 1:14 am
ruden wrote:
Mon Oct 07, 2019 9:38 pm
mrtools

I have a question.
If I'm not mistaken, this is a snippet for nrp coloring.

Code: Select all

void CleanPoint(int i,double& first[],double& second[])
{
   if (i>=Bars-3) return;
   if ((second[i]  != EMPTY_VALUE) && (second[i+1] != EMPTY_VALUE))
        second[i+1] = EMPTY_VALUE;
   else
      if ((first[i] != EMPTY_VALUE) && (first[i+1] != EMPTY_VALUE) && (first[i+2] == EMPTY_VALUE))
          first[i+1] = EMPTY_VALUE;
}

void PlotPoint(int i,double& first[],double& second[],double& from[])
{
   if (i>=Bars-2) return;
   if (first[i+1] == EMPTY_VALUE)
      if (first[i+2] == EMPTY_VALUE) 
            { first[i]  = from[i];  first[i+1]  = from[i+1]; second[i] = EMPTY_VALUE; }
      else  { second[i] = from[i];  second[i+1] = from[i+1]; first[i]  = EMPTY_VALUE; }
   else     { first[i]  = from[i];                           second[i] = EMPTY_VALUE; }
}
There are some indicators that don't have these two lines.

Code: Select all

if (i>=Bars-3) return;
if (i>=Bars-2) return;
Do those two lines affect nrp coloring?
Yes those 2 lines are added for using #property strict.
I got it thanks

Re: Coding Help

#1068
Dear coders,

Please Help. I am not from coding / programming background.

What code / line should I add in Indicator file so that I get Timeframe selected ( i.e. H1, H4 etc ) ( in respective Indi )
plotted above / below on up / down arrows in any indicator.
or
What code / line should I add in Indicator file so that I get TEXT selected ( Input : Text ) ( in respective Indi )
plotted above / below on up / down arrows in any indicator.

Please Share Code.

Thanks.
Capture.JPG

Re: Coding Help

#1069
Dear experts,

I was trying to code a simple EA with the "Super smoothed average trend 1.2" by Jimmy, which is an indicator in the Top 10 NRP indicators list in here (attached below for ease of access). The idea is to make a buy order when the indicator turns Green (by default) and sell order vice versa. I was trying to find the indicator values using iCustom function during backtesting as shown below.

Code: Select all

#include <stdlib.mqh>

extern int                AvgPeriod1 = 34;
extern ENUM_APPLIED_PRICE AvgPrice1 = PRICE_CLOSE;

void OnTick()
{  
   double CustomIndi0 = iCustom(Symbol(), 15, "Super smoothed average trend 1.2", AvgPeriod1, AvgPrice1, 0, 1);
   Print("The value of Indicator Buffer 0 is: ", CustomIndi0);
   double CustomIndi1 = iCustom(Symbol(), 15, "Super smoothed average trend 1.2", AvgPeriod1, AvgPrice1, 1, 1);
   Print("The value of Indicator Buffer 1 is: ", CustomIndi1);
   double CustomIndi2 = iCustom(Symbol(), 15, "Super smoothed average trend 1.2", AvgPeriod1, AvgPrice1, 2, 1);
   Print("The value of Indicator Buffer 2 is: ", CustomIndi2);
   double CustomIndi3 = iCustom(Symbol(), 15, "Super smoothed average trend 1.2", AvgPeriod1, AvgPrice1, 3, 1);
   Print("The value of Indicator Buffer 3 is: ", CustomIndi3);
   double CustomIndi4 = iCustom(Symbol(), 15, "Super smoothed average trend 1.2", AvgPeriod1, AvgPrice1, 4, 1);
   Print("The value of Indicator Buffer 4 is: ", CustomIndi4);
   double CustomIndi5 = iCustom(Symbol(), 15, "Super smoothed average trend 1.2", AvgPeriod1, AvgPrice1, 5, 1);
   Print("The value of Indicator Buffer 5 is: ", CustomIndi5);
   double CustomIndi6 = iCustom(Symbol(), 15, "Super smoothed average trend 1.2", AvgPeriod1, AvgPrice1, 6, 1);
   Print("The value of Indicator Buffer 6 is: ", CustomIndi6);
   double CustomIndi7 = iCustom(Symbol(), 15, "Super smoothed average trend 1.2", AvgPeriod1, AvgPrice1, 7, 1);
   Print("The value of Indicator Buffer 7 is: ", CustomIndi7);
   double CustomIndi8 = iCustom(Symbol(), 15, "Super smoothed average trend 1.2", AvgPeriod1, AvgPrice1, 8, 1);
   Print("The value of Indicator Buffer 8 is: ", CustomIndi8);
 } 
When I execute this, it returns Empty_Value in Line Index 2 and 3, while the rest of them are zero. I tried using backtest data where the indicator shows green, as well as red, but the return values did not change at all.

Any help would be highly appreciated. Thank you very much for your time.
Super smoothed average trend 1.2.ex4
(40.92 KiB) Downloaded 34 times
Capture.PNG

Re: Coding Help

#1070
schemman wrote:
Tue Nov 19, 2019 10:01 am
Dear experts,

I was trying to code a simple EA with the "Super smoothed average trend 1.2" by Jimmy, which is an indicator in the Top 10 NRP indicators list in here (attached below for ease of access). The idea is to make a buy order when the indicator turns Green (by default) and sell order vice versa. I was trying to find the indicator values using iCustom function during backtesting as shown below.

Code: Select all

#include <stdlib.mqh>

extern int                AvgPeriod1 = 34;
extern ENUM_APPLIED_PRICE AvgPrice1 = PRICE_CLOSE;

void OnTick()
{  
   double CustomIndi0 = iCustom(Symbol(), 15, "Super smoothed average trend 1.2", AvgPeriod1, AvgPrice1, 0, 1);
   Print("The value of Indicator Buffer 0 is: ", CustomIndi0);
   double CustomIndi1 = iCustom(Symbol(), 15, "Super smoothed average trend 1.2", AvgPeriod1, AvgPrice1, 1, 1);
   Print("The value of Indicator Buffer 1 is: ", CustomIndi1);
   double CustomIndi2 = iCustom(Symbol(), 15, "Super smoothed average trend 1.2", AvgPeriod1, AvgPrice1, 2, 1);
   Print("The value of Indicator Buffer 2 is: ", CustomIndi2);
   double CustomIndi3 = iCustom(Symbol(), 15, "Super smoothed average trend 1.2", AvgPeriod1, AvgPrice1, 3, 1);
   Print("The value of Indicator Buffer 3 is: ", CustomIndi3);
   double CustomIndi4 = iCustom(Symbol(), 15, "Super smoothed average trend 1.2", AvgPeriod1, AvgPrice1, 4, 1);
   Print("The value of Indicator Buffer 4 is: ", CustomIndi4);
   double CustomIndi5 = iCustom(Symbol(), 15, "Super smoothed average trend 1.2", AvgPeriod1, AvgPrice1, 5, 1);
   Print("The value of Indicator Buffer 5 is: ", CustomIndi5);
   double CustomIndi6 = iCustom(Symbol(), 15, "Super smoothed average trend 1.2", AvgPeriod1, AvgPrice1, 6, 1);
   Print("The value of Indicator Buffer 6 is: ", CustomIndi6);
   double CustomIndi7 = iCustom(Symbol(), 15, "Super smoothed average trend 1.2", AvgPeriod1, AvgPrice1, 7, 1);
   Print("The value of Indicator Buffer 7 is: ", CustomIndi7);
   double CustomIndi8 = iCustom(Symbol(), 15, "Super smoothed average trend 1.2", AvgPeriod1, AvgPrice1, 8, 1);
   Print("The value of Indicator Buffer 8 is: ", CustomIndi8);
 } 
When I execute this, it returns Empty_Value in Line Index 2 and 3, while the rest of them are zero. I tried using backtest data where the indicator shows green, as well as red, but the return values did not change at all.

Any help would be highly appreciated. Thank you very much for your time.
Would make a wild guess it is using buffer#3 which would be the trend buffer, which would be if trend = 1 = buy and trend =-1 = sell.


  1. Similar Topics

    1. Help coding simple EA

      5 Replies 621 Views

      by Griff90, Tue Nov 13, 2018 8:36 am in Coding Help

      5 Replies
      621 Views
    2. Coding Help : telegram EA notification

      6 Replies 3049 Views

      by redbulls60, Sun Jan 21, 2018 9:45 pm in Coding Help

      6 Replies
      3049 Views

Return to “Coding Help”

Who is online

Users browsing this forum: CommonCrawl [Bot], Trendiction [Bot] and 3 guests