Centaur wrote: Thu Oct 27, 2022 1:25 am Really interesting approach, I've also done some reading and they suggest using the function SymbolInfoSessionTrade, so I came up with the following function (seems to be working so far):

Code: Select all

//+------------------------------------------------------------------+
//| Function: Check if market is Open                                |
//+------------------------------------------------------------------+
bool MarketOpen()
  {
   datetime from = 0;
   datetime to = 0;
   datetime now = TimeCurrent();
   uint session_index = 0;
   MqlDateTime today;
   TimeToStruct(now, today);
   if(SymbolInfoSessionTrade(_Symbol, (ENUM_DAY_OF_WEEK) today.day_of_week, session_index, from, to))
     {
      MqlDateTime from_time;
      MqlDateTime to_time;
      TimeToStruct(from, from_time);
      TimeToStruct(to, to_time);
      int from_time_seconds = from_time.sec + from_time.min * 60 + from_time.hour * 3600;
      int to_time_seconds = to_time.sec + to_time.min * 60 + to_time.hour * 3600;
      int now_seconds = today.sec + today.min * 60 + today.hour * 3600;
      if(now_seconds >= from_time_seconds && now_seconds <= to_time_seconds)
         return(true);
      return(false);
     }
   return(false);
  }

So you are basically checking if the current time is within the allowed trading session time for that symbol.

That is a nice idea. I can extend my code to first check if trading is allowed and then call OrderSend. If trading is not allowed, I can do what I have mentioned in my post above.

xpf2003 wrote: Thu Oct 27, 2022 1:48 am So you are basically checking if the current time is within the allowed trading session time for that symbol.

That is a nice idea. I can extend my code to first check if trading is allowed and then call OrderSend. If trading is not allowed, I can do what I have mentioned in my post above.

Yes sounds like a working solution

mrtools wrote: Sun Oct 23, 2022 12:44 pm Added all the prices, to the version you posted.

Dear mrtools… Could you please color the upper and lower bands based on slope similar to what you are doing for the middle line… thanks a lot

mrtools wrote: Sun Oct 23, 2022 12:44 pm Added all the prices, to the version you posted.

Just a gentle reminder… thanks again

Dear mrtools… Could you please color the upper and lower bands based on slope similar to what you are doing for the middle line… thanks a lot

Daim2574 wrote: Sun Oct 30, 2022 4:08 am Just a gentle reminder… thanks again

Dear mrtools… Could you please color the upper and lower bands based on slope similar to what you are doing for the middle line… thanks a lot

Hi Daim2574,

This is mainly Centaur's thread and really don't want to get in the way of the excellent work he is doing in here.

mrtools wrote: Sun Oct 30, 2022 5:01 am Hi Daim2574,

This is mainly Centaur's thread and really don't want to get in the way of the excellent work he is doing in here.

No worries… thanks anyway mrtools

Can anyone convert these indicators to MT4?

https://www.tradingview.com/script/Q9xt ... tors-in-1/

https://www.tradingview.com/script/PxLq ... nd-Ribbon/

Thank you!

Donchian Trend Ribbon
Converted tradingview indicator: https://www.tradingview.com/script/PxLq ... nd-Ribbon/

Centaur wrote: Thu Nov 03, 2022 11:57 pm Donchian Trend Ribbon
Converted tradingview indicator: https://www.tradingview.com/script/PxLq ... nd-Ribbon/

Very crude coding, will look at a more compact coding method. Best settings I think is 10, all dependent on your system.

Centaur wrote: Thu Nov 03, 2022 11:57 pm Donchian Trend Ribbon
Converted tradingview indicator: https://www.tradingview.com/script/PxLq ... nd-Ribbon/

How do you use this indicator?